Project

General

Profile

Actions
Copy link

Bug #701

open

Bug #697: Endorsement issues

Edit + Endorsement

Added by Greg Krabbenhoft 6 months ago. Updated about 2 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Leo Esaki
Start date:
10/17/2024
Due date:
% Done:

0%

Estimated time:

Description

Currently only one change is allowed, this needs to be changed to two separate items, edit and endorsement. An added set of required radio buttons on the vehicle details edit page should be added with a corresponding field in the database. These should be empty upon page load, and required to save. The options should be "Vehicle Correction" and "Vehicle Transfer"

Actions
Copy link
 #1

Updated by Leo Esaki 5 months ago

  • Status changed from New to QA
  • Assignee changed from Leo Esaki to George Howington

https://gitlab.com/nfp-cross-border/polmaker-v3/-/tree/377-add-a-new-feature-on-edit-and-endorsement?ref_type=heads

Hi George.

I completed this ticket. Please take a look and if you have anything on this, please let me know.

Thanks, Leo.

Actions
Copy link
 #3

Updated by George Howington 2 months ago

  • Status changed from QA to In Progress
  • Assignee changed from George Howington to Leo Esaki

Hi Leo,

Three issues.

(1) there appears a merge conflict. Please resolve this conflict
(2) Please update this branch 'from' master. I see other issues already resolved.
(3) I don't see the options, "The options should be "Vehicle Correction" and "Vehicle Transfer""

Thanks Leo!!

"

Actions
Copy link
 #4

Updated by Leo Esaki about 2 months ago

Hi George.

I resloved conflts. Anyways, can you please elaborate your third issue again?

(3) I don't see the options, "The options should be "Vehicle Correction" and "Vehicle Transfer""

https://gitlab.com/nfp-cross-border/polmaker-v3/-/merge_requests/388/pipelines

Thanks,
Leo

Actions
Copy link
 #5

Updated by Leo Esaki about 2 months ago

  • Status changed from In Progress to QA
  • Assignee changed from Leo Esaki to George Howington
Actions
Copy link
 #6

Updated by George Howington about 2 months ago

  • Status changed from QA to In Progress
  • Assignee changed from George Howington to Leo Esaki

Hi Leo,

On point number 3, 'Vehicle Correction' is an edit to the vehicles. This should not run through the rate. 'Vehicle transfer' is a vehicle replacement and should run through the rater.

Thanks,
--George

Actions
Copy link
 #7

Updated by George Howington about 2 months ago

Hi Leo,

As we discussed, there is a question of whether an edit is allowed. Here is how we can handle this question:

Both 'vehicle correction' and 'vehicle transfer' should run through the rater.
(1) If 'vehicle correction' is marked, but there is a rate change involved
(a) trigger an error explaining the edit will result in a rate change and needs to be run as a 'vehicle transfer.'

(2) If 'vehicle correction' is marked, and there is 'no' rate change involved
(a) Otherwise, an edit to replace necessary information is allowed without an endorsement.

(3) If 'vehicle transfer' is selected, run an endorsement even if no rate change is involved.

Thanks,
--George

Actions
Copy link

Also available in: Atom PDF